fix the rounding bug in roundShortest method #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @dreamerjackson. Before diving in code review, could you provide proper benchmarks too? So all be aware of the importance of this optimization. |
|
@cmars @chrismrivera @soyangel the fix can merge? |
|
Hi @dreamerjackson. I kinda forgot about your PR, I apologize. Could you rename the pull request title to match code content? As you said it's about fixing the bug, not optimization at all. Below I provided the additional benchmarks. goos: windows
|
dreamerjackson
changed the title
|
@mwoss i have fixed the title description，please review it again , thx~ |
mwoss
approved these changes
Jul 7, 2020
fairyhunter13
added a commit
to fairyhunter13/decimal
that referenced
this pull request
Jul 12, 2020
* fix: fix rounding in FormatFloat fallback path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimization roundShortest method for effectiveness
which had apply in go source code: go-source-strconv